November 23, 2020, 12:01:52 PM

News:

Looking for a good read? Check out the SimpleDesk Team Blog.


Upgrade Roadmap

Started by tfs, February 02, 2019, 02:43:12 PM

Previous topic - Next topic

tfs

Looking to discuss eventual upgrade of my help desk from SMF 2.0.x to whatever comes next. Going to be prudent if/when PHP upgrade gets forced on me via Ionos hosting or a new vulnerability arises.

Current SMF version: SMF 2.0.15
GD version: bundled (2.1.0 compatible)
Database Server: MySQL
MySQL version: 5.5.60-0+deb7u1-log
PHP: 5.6.40
Server version: Apache
SimpleDesk  2.0 SVN r537 (Slightly customized)

https://secure.php.net/supported-versions.php

Anyone else looking at getting to PHP 7.1+?
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

SleePy

7.1 should be fine.  I haven't tested 7.2 yet.
SMF 2.0.15 works fine with 7.1 and so does SD.

SD will most likely work with 7.2, but SMF has some warnings and issues.
Jeremy D — Spare-Developer

tfs

When I change PHP to 7.1 I get this in the error log...

https://www.xyz.com/index.php?action=helpdesk;sa=tickets
2: Parameter 1 to shd_buffer_replace() expected to be a reference, value given


And this:

https://www.xyz.com/index.php?action=helpdesk;sa=tickets
2: Parameter 1 to KB_ob() expected to be a reference, value given


Apparently the second one is due to a Knowledge Base I have installed, but it appears that the first is from SimpleDesk, and is located in \Sources\sd_source\Subs-SimpleDesk.php
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

tfs

Still getting the following error when updating PHP to 7.1. I'm not qualified to fix it.

https://www.xyz.com/index.php?action=helpdesk;sa=tickets
2: Parameter 1 to shd_buffer_replace() expected to be a reference, value given

A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

tfs

According to this: http://www.simpledesk.net/development/api/

shd_buffer_replace may only be a problem when in help desk only mode, which is what I'm using.


package

subs
shd_buffer_replace()

shd_buffer_replace(  $buffer)

Last-minute buffer replacements to be made, e.g. removing unwanted content in helpdesk-only mode.
Parameters
$buffer
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

SleePy

What version of SMF and SD?

Are you doing any placements of SD like in the board index, unread replies or other areas?
Jeremy D — Spare-Developer

tfs

Current SMF version: SMF 2.0.15
GD version: bundled (2.1.0 compatible)
MySQL version: 5.5.60-0+deb7u1-log
PHP: 5.6.40
Server version: Apache
SimpleDesk  2.0 SVN r537 (Slightly customized)

I'm not quite sure what this means:

QuoteAre you doing any placements of SD like in the board index, unread replies or other areas?

I've done a few customizations over the years. Added a column or two to the ticket grids. Adjusted widths on the grids. Set the Additional Info area to collapsed by default. Added a few custom fields to the ticket display template.

But when you say Board Index maybe you mean the forum? In this case there is no forum and no personal messages available. That's all turned off. Help desk only.
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

SleePy

In the sd_sources/Subs-SimpleDes.php


function shd_buffer_replace(&$buffer)


Replace with


function shd_buffer_replace($buffer)


This is fixed in 2.1
Jeremy D — Spare-Developer

tfs

Thanks, will give it a try and report back.
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.