News:

Get the latest news and updates on SimpleDesk!

Main Menu

Topic solved
This topic is marked as solved and as such require no attention unless you want to bump this issue.

Bug icons

Started by wintstar, November 10, 2015, 04:40:06 PM

Previous topic - Next topic

wintstar

SimpleDesk version: SimpleDesk 2.0.1
SMF version:  SMF 2.1 Beta 2

Latest revision from the GitHub. Download is of branch smf21 from 08.11.2015.

MySQLi version: 5.6.25
PHP: 5.6.11
SMF 2.1 Beta 2 is from the latest revision from the GitHub 08.11.2015

Some icons are not displayed:








My suggested solution:

Creates a new folder "icons" in root/Themes/default/images/simpledesk/. Inserts the icons in this folder "icons" and the "helpdesk_icons.css" in root/Themes/default/css/:




Download icons and helpdesk_icons.css

Open root/Sources/sd_source/Subs-SimpleDeskAdmin.php

find
function shd_admin_bootstrap(&$admin_areas)
{
    global $sourcedir, $modSettings, $txt, $context, $scripturl;

replaces with
function shd_admin_bootstrap(&$admin_areas)
{
    global $sourcedir, $modSettings, $txt, $context, $scripturl, $settings;

    // Load some extra CSS
    $context['html_headers'] .= '
    <link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/css/helpdesk_icons.css" />';

find
                    'icon' => 'shd/simpledesk.png',
replaces with
                    'icon' => 'shd_simpledesk',
find
                    'icon' => 'shd/options.png',
replaces with
                    'icon' => 'shd_options',
find
                    'icon' => 'shd/cannedreplies.png',
replaces with
                    'icon' => 'shd_cannedreplies',
find
                    'icon' => 'shd/custom_fields.png',
replaces with
                    'icon' => 'shd_custom_fields',
find
                    'icon' => 'shd/departments.png',
replaces with
                    'icon' => 'shd_departments',
find
                    'icon' => 'shd/permissions.png',
replaces with
                    'icon' => 'shd_permissions',
find
                    'icon' => 'shd/plugins.png',
replaces with
                    'icon' => 'shd_plugins',
find
                    'icon' => 'shd/maintenance.png',
replaces with
                    'icon' => 'shd_maintenance',

Open root/Sources/sd_source/Subs-SimpleDesk.php

find
function shd_main_menu(&$menu_buttons)
{
    global $context, $txt, $scripturl, $modSettings;

replaces with
function shd_main_menu(&$menu_buttons)
{
    global $context, $txt, $scripturl, $modSettings, $settings;

    // Load some extra CSS
    $context['html_headers'] .= '
    <link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/css/helpdesk_icons.css" />';




After solution:






SleePy

Sounds great, I hadn't gotten around to fixing that yet.  Will add it to the bug list.

Your welcome to fork the project, do your changes and issue a pull request back.  All you need to do on that is sign off the commit :)
Jeremy D — Spare-Developer

wintstar

I'm just getting started with Github and not understand anything. I'll create a Fork in my github and add there a changes. Then I'll try a pull request to create.

wintstar

only thing missing is the change in package-info.xml

SleePy

I've committed the change.
Jeremy D — Spare-Developer