SimpleDesk

SimpleDesk! => SimpleDesk Tracker => Topic started by: wintstar on November 10, 2015, 04:40:06 PM

Title: Bug icons
Post by: wintstar on November 10, 2015, 04:40:06 PM
SimpleDesk version: SimpleDesk 2.0.1
SMF version:  SMF 2.1 Beta 2

Latest revision from the GitHub. Download is of branch smf21 from 08.11.2015.

MySQLi version: 5.6.25
PHP: 5.6.11
SMF 2.1 Beta 2 is from the latest revision from the GitHub 08.11.2015

Some icons are not displayed:


(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fbug_menu_index.png&hash=abef9346ec3e29309fb00a62f257fb2e6402b549)



(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fbug_menu_coresetting.png&hash=3df916f424a7b3a83ef35e1bb72d11ae662d509a)

My suggested solution:

Creates a new folder "icons" in root/Themes/default/images/simpledesk/. Inserts the icons in this folder "icons" and the "helpdesk_icons.css" in root/Themes/default/css/:

(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fshd_admin_icons.png&hash=b9097bda7fd5144baf9b748ddd1f6240be545bd3)

(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fshd_generic_icons.png&hash=cad339adca90f6d9badf72b1eb7e52f631f495c0)
Download icons and helpdesk_icons.css (http://scaricare.de/upload/shd/new_helpdesk_icons_css.zip)

Open root/Sources/sd_source/Subs-SimpleDeskAdmin.php

find
function shd_admin_bootstrap(&$admin_areas)
{
    global $sourcedir, $modSettings, $txt, $context, $scripturl;

replaces with
function shd_admin_bootstrap(&$admin_areas)
{
    global $sourcedir, $modSettings, $txt, $context, $scripturl, $settings;

    // Load some extra CSS
    $context['html_headers'] .= '
    <link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/css/helpdesk_icons.css" />';

find
                    'icon' => 'shd/simpledesk.png',
replaces with
                    'icon' => 'shd_simpledesk',
find
                    'icon' => 'shd/options.png',
replaces with
                    'icon' => 'shd_options',
find
                    'icon' => 'shd/cannedreplies.png',
replaces with
                    'icon' => 'shd_cannedreplies',
find
                    'icon' => 'shd/custom_fields.png',
replaces with
                    'icon' => 'shd_custom_fields',
find
                    'icon' => 'shd/departments.png',
replaces with
                    'icon' => 'shd_departments',
find
                    'icon' => 'shd/permissions.png',
replaces with
                    'icon' => 'shd_permissions',
find
                    'icon' => 'shd/plugins.png',
replaces with
                    'icon' => 'shd_plugins',
find
                    'icon' => 'shd/maintenance.png',
replaces with
                    'icon' => 'shd_maintenance',

Open root/Sources/sd_source/Subs-SimpleDesk.php

find
function shd_main_menu(&$menu_buttons)
{
    global $context, $txt, $scripturl, $modSettings;

replaces with
function shd_main_menu(&$menu_buttons)
{
    global $context, $txt, $scripturl, $modSettings, $settings;

    // Load some extra CSS
    $context['html_headers'] .= '
    <link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/css/helpdesk_icons.css" />';




After solution:

(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fmenu_index.png&hash=9a71be98067ea3d54520377f9e376271785dae36)

(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fmenu_coresetting.png&hash=a92baf30d6f232078e9686357f497832fa765cf4)

(https://www.simpledesk.net/community/proxy.php?request=http%3A%2F%2Fscaricare.de%2Fupload%2Fshd%2Fmenu_helpdesk.png&hash=e5e8eb237d6f8a71bbb056420e68def06923215c)
Title: Re: Bug icons
Post by: SleePy on November 12, 2015, 11:12:03 PM
Sounds great, I hadn't gotten around to fixing that yet.  Will add it to the bug list.

Your welcome to fork the project, do your changes and issue a pull request back.  All you need to do on that is sign off the commit :)
Title: Re: Bug icons
Post by: wintstar on November 13, 2015, 04:16:23 AM
I'm just getting started with Github and not understand anything. I'll create a Fork in my github and add there a changes. Then I'll try a pull request to create.
Title: Re: Bug icons
Post by: wintstar on November 27, 2015, 08:50:13 PM
only thing missing is the change in package-info.xml
Title: Re: Bug icons
Post by: SleePy on November 29, 2015, 02:02:39 PM
I've committed the change.