SimpleDesk

SimpleDesk! => SimpleDesk Support => Topic started by: wintstar on November 08, 2015, 01:05:33 PM

Title: Bug in Standalone Options
Post by: wintstar on November 08, 2015, 01:05:33 PM
   SimpleDesk version: SimpleDesk 2.0.1
   SMF version:  SMF 2.1 Beta 2

Warning: Missing argument 2 for shd_error_types() in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 623

Warning: Missing argument 3 for shd_error_types() in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 623

Warning: Missing argument 4 for shd_error_types() in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 623

Warning: Missing argument 5 for shd_error_types() in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 623

Notice: Undefined variable: file in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 631

Notice: Undefined variable: error_message in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 631

Notice: Undefined variable: file in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 633

Notice: Undefined variable: error_message in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 633

Notice: Undefined variable: error_message in C:\xampp\htdocs\smf21\Sources\sd_source\Subs-SimpleDeskAdmin.php on line 633

Error log:
Type of error: General
2: Invalid argument supplied for foreach()
xxx//localhost/smf21/index.php?action=admin;area=helpdesk_options;sa=standalone;d2f5d3372=xxxx
File: C:/xampp/htdocs/smf21/Sources/ManageServer.php
Line: 770

   
Title: Re: Bug in Standalone Options
Post by: ccbtimewiz on November 10, 2015, 02:23:48 AM
You are using the latest revision from the GitHub?

Can you provide steps to what you did before the errors were thrown?
Title: Re: Bug in Standalone Options
Post by: wintstar on November 10, 2015, 03:44:05 AM
Yes i have the latest revision from the GitHub. Download is of branch smf21 from 08.11.2015. SMF

MySQLi version: 5.6.25
PHP: 5.6.11
SMF 2.1 Beta 2 is from the latest revision from the GitHub 08.11.2015


The error I noticed, when configure the modification. 


I have found some bugs. Mainly in the plugin system. I'll post in separate threads. A language string seems to me to be missing core_settings_disabled for an error message. I must still accurately check.
Title: Re: Bug in Standalone Options
Post by: wintstar on November 14, 2015, 12:55:55 PM
Solution

open root/Sources/sd_source/SimpleDesk-Admin.php
find
    if ($return_config)
    {
        call_integration_hook('shd_hook_admin_standalone', array(&$config_vars, &$return_config));
        return $config_vars;
    }


replaces with
        call_integration_hook('shd_hook_admin_standalone', array(&$config_vars, &$return_config));
        return $config_vars;
Title: Re: Bug in Standalone Options
Post by: wintstar on November 29, 2015, 07:27:26 AM
Can be closed. Has been corrected with Added save dialog notice (https://github.com/SimpleDesk/SimpleDesk/commit/1ebd1681ffcde53a35e03a1c8c5b91f1c5f56982).