Topic solved
This topic is marked as solved and as such require no attention unless you want to bump this issue.

[Fixed] 2.0 Sorting Assigned To Me grid by status doesn't work

Started by tfs, September 07, 2011, 03:51:25 PM

Previous topic - Next topic

tfs

When I try to sort by the "Status" column in the "Assigned to Me grid", it actually sorts by the "Started By" column.
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

tfs

Arantor posted a fix for this on git.

In: sd_template/SimpleDesk.template.php

Change This:
<td width="17%" class="shd_nowrap"><img src="', $settings['default_images_url'], '/simpledesk/status.png" class="shd_smallicon" alt="" /> ', template_shd_menu_header('starter', $txt['shd_ticket_status']), '</td>';

To This:
<td width="17%" class="shd_nowrap"><img src="', $settings['default_images_url'], '/simpledesk/status.png" class="shd_smallicon" alt="" /> ', template_shd_menu_header('status', $txt['shd_ticket_status']), '</td>';

I have not tested this fix, but I have a high confidence level that it's correct.
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

tfs

As long as I'm posting the fix for that one, I may as well post the other fix in the same file where the department link wasn't always included properly in the grid sorting.

Change this:
$html = '<a href="' . $scripturl . '?action=helpdesk;sa=' . $_REQUEST['sa'] . ($_REQUEST['sa'] == 'viewblock' ? ';block=' . $_REQUEST['block'] : '') . $link . '">' . $string . '</a> ';

To this:
$html = '<a href="' . $scripturl . '?action=helpdesk;sa=' . $_REQUEST['sa'] . ($_REQUEST['sa'] == 'viewblock' ? ';block=' . $_REQUEST['block'] : '') . $link . $context['shd_dept_link'] . '">' . $string . '</a> ';

A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

SleePy

I merged his commit last night.  Although I realize I must have a bug with something since it didn't pick up the commit.  I thought It would work from how I used the commit data (it has tracking for each commit author rather than the one who pushed the commit).
Jeremy D — Spare-Developer