SimpleDesk

SimpleDesk! => SimpleDesk Support => Small Official Mod Support => Topic started by: tfs on February 15, 2010, 12:13:31 AM

Title: Error Log Counter
Post by: tfs on February 15, 2010, 12:13:31 AM
Error Log Counter (http://custom.simplemachines.org/mods/index.php?mod=2441)

It's a thing of beauty!!!  Thanks!
Title: Re: Error Log Counter
Post by: tyty1234 on February 15, 2010, 03:59:06 AM
I'd say, this is a pretty awesome mod.
Thanks for sharing. ;D
Title: Re: Error Log Counter
Post by: Gruffen on February 15, 2010, 04:39:17 AM
Glad you like it :)

And it cuts down my dev time in building stuff, which is no bad thing :)

Hmm, maybe I should have this as an option in my auto installer to drop in (I have a one click installer for SMF builds, so I can just refresh the entire installation back to 'factory default' in a matter of seconds, and should probably have this as an option in the 2.x builds)
Title: Re: Error Log Counter
Post by: hadesflames on February 19, 2010, 09:34:44 PM
Quote from: Arantor on February 15, 2010, 04:39:17 AM
Glad you like it :)

And it cuts down my dev time in building stuff, which is no bad thing :)

Hmm, maybe I should have this as an option in my auto installer to drop in (I have a one click installer for SMF builds, so I can just refresh the entire installation back to 'factory default' in a matter of seconds, and should probably have this as an option in the 2.x builds)

Interesting, mind sending that my way? I don't how many times I've had to re-install SMF on my localhost =P
Title: Re: Error Log Counter
Post by: Gruffen on February 20, 2010, 05:29:49 AM
The install is so ugly it isn't funny. What it does is remove the designated folder, unpack the relevant .zip file in to a newly remade version, and brute force the parameters I give it into $_POST by modifying the installer. It proceeds to modify a few other things (like setting disableTemplateEval) then just pushes into the SMF installer.

It is insanely ugly, has a known bug on the 1.x series and is hardly an example of good coding.
Title: Re: Error Log Counter
Post by: hadesflames on February 20, 2010, 11:44:12 AM
I couldn't care less =P

'slong as it works. ;)
Title: Re: Error Log Counter
Post by: live627 on February 20, 2010, 06:13:53 PM
Error Log Counter is helpful for tracking error numbers.

Have you thought of adding it to the header>
Title: Re: Error Log Counter
Post by: Gruffen on February 20, 2010, 06:19:18 PM
We hadn't, but that's not a bad idea.

On my local I have a modded version that attaches it to the 'Admin' button instead of to the error log item itself, which is also useful, but I'd personally be keen to keep it out of the header since then it gets into the realms of theme edits and support...
Title: Re: Error Log Counter
Post by: live627 on February 23, 2010, 01:16:05 AM
I looked at the code and noticed there is no call to the db_free_result function. Something to look into
Title: Re: Error Log Counter
Post by: Gruffen on February 23, 2010, 03:33:59 AM
It isn't actually necessary in this instance; not only will it be freed on script end anyway, the result is consumed in its entirety anyway - in fact it was of the suggestions for performance in 2.1 that the many calls to db_free_result could actually be skipped because the entire resultset is consumed and thus not being held up on the DB end (which is the normal reason you need to call it)
Title: Re: Error Log Counter
Post by: ~DS~ on February 23, 2010, 12:26:45 PM
Quote from: live627 on February 20, 2010, 06:13:53 PM
Error Log Counter is helpful for tracking error numbers.

Have you thought of adding it to the header>

Didn't we already have on?
Your Show Number of Errors at Top of Forum Mod.
Title: Re: Error Log Counter
Post by: live627 on March 04, 2010, 08:07:02 PM
Actually I made that post before I got the mod
Title: Re: Error Log Counter
Post by: Prenses on March 31, 2010, 09:47:31 AM
hello,

lt's a very good and intersting mod. thanks but  :( i'ts only for smf 2

why it's not compatible with smf 1 ?  :o

l think if it's compatible with smf 1 more poeple use it. because it's an important modification.

if it easy to make it for smf 1.

could you make it one time please.

Greets.
Title: Re: Error Log Counter
Post by: Gruffen on March 31, 2010, 10:04:59 AM
Short answer: no.

Long answer: Partly I refuse to completely rewrite the mod for SMF 1.1, and partly because every single custom theme will have to be modified separately by hand. To be honest I'd rather drop any kind of 1.1 support so I can spend more time writing new and interesting modifications instead of having to *REPEATEDLY* going over the same problems with 1.1 users. I'd rather write a new mod than answer 10 people about modifying a custom theme, and believe me that's the way it'll turn out.

Same reason SimpleDesk will not support SMF 1.1 at all.
Title: Re: Error Log Counter
Post by: Prenses on March 31, 2010, 10:26:35 AM
l understand.. ok thanks for short and long answer.

life is really not fair  :-[
Title: Re: Error Log Counter
Post by: Gruffen on March 31, 2010, 10:44:45 AM
Just to clarify, you would have to manually edit the code on your theme unless you're using the default theme (since it appears in the main menu)
Title: Re: Error Log Counter
Post by: Hoodie on April 19, 2010, 04:12:35 AM
Ever thought about doing this for the Moderate Posts part under MODERATE on the main menu and Moderation Center?  Thought it would be a good idea for those moderators who turn notification off.
Title: Re: Error Log Counter
Post by: Gruffen on April 19, 2010, 06:20:28 AM
I hadn't thought about it, but it's not a bad idea at all, that.
Title: Re: Error Log Counter
Post by: kcmartz on December 25, 2010, 11:25:42 PM
Installed again. I had over 20,000 errors! I had not gone into the error log once since redoing whole site/forum brand new. I got it down to about 4 errors that keep re-appearing. Other than that no errors!

(Sent from my Google Notebook - cr-48 on Verizon Wireless 3g mode)
Title: Re: Error Log Counter
Post by: ~DS~ on December 31, 2010, 02:34:08 PM
I have used that mod for as long as I can remember and never got those "20,000" errors, there must be other mods that conflict with it.
Title: Re: Error Log Counter
Post by: Gruffen on December 31, 2010, 08:56:36 PM
No, he had 20k errors from other stuff but never noticed before...
Title: Re: Error Log Counter
Post by: ~DS~ on January 01, 2011, 07:08:41 PM
Quote from: Gruffen on December 31, 2010, 08:56:36 PM
No, he had 20k errors from other stuff but never noticed before...
Then it's unrelated to this mod.
Title: Re: Error Log Counter
Post by: Spoogs on January 01, 2011, 07:11:52 PM
he never said it was ;)
Title: Re: Error Log Counter
Post by: cσσкιє мσηѕтєя on January 01, 2011, 09:39:11 PM
DS, kcmartz is saying that thanks to this mod, he noticed those 20,000 errors that he had before he installed it...
Title: Re: Error Log Counter
Post by: ~DS~ on July 07, 2011, 06:08:04 PM
Working in 2.0 by emulating to RC3
Title: Re: Error Log Counter
Post by: Spoogs on July 07, 2011, 06:09:47 PM
http://custom.simplemachines.org/mods/index.php?mod=2441
Should install without emulation... though I'd agree the packages should be updated here as well.
Title: Re: Error Log Counter
Post by: Gruffen on July 07, 2011, 06:25:42 PM
Well, the SMF mod site doesn't agree, even though the package has '2.0 RC2, 2.0 RC3, 2.0 RC4, 2.0 RC5, 2.0-2.0.99' in it and does indeed work on 2.0 final.

The package needs resubmitting, however, because it's broken.
Title: Re: Error Log Counter
Post by: Spoogs on July 07, 2011, 06:29:41 PM
Broken in what sense..? I'm using and it seems fine (at least from an admin standpoint, and haven't heard any complaints from my members).
Title: Re: Error Log Counter
Post by: Gruffen on July 07, 2011, 06:34:20 PM
Quote from: Spoogs on July 07, 2011, 06:29:41 PM
Broken in what sense..? I'm using and it seems fine (at least from an admin standpoint, and haven't heard any complaints from my members).

That there is absolutely no way it can ever be parsed on the SMF modsite because of the way it was packaged originally.
Title: Re: Error Log Counter
Post by: Spoogs on July 07, 2011, 06:44:14 PM
Oh so it's just a matter of the package on the modsite, not that there's any issue with the mod itself... correct?
Title: Re: Error Log Counter
Post by: Gruffen on July 07, 2011, 06:47:21 PM
I haven't checked the one on the mod site. The two files that are in SVN are known to be correct and work just perfectly. I can trivially build a new package and post it here for upload (and update to sm.org) if someone wants to do that.
Title: Re: Error Log Counter
Post by: Spoogs on July 07, 2011, 06:52:30 PM
Sure go ahead, I'll update sm.org
Title: Re: Error Log Counter
Post by: Gruffen on July 07, 2011, 06:55:48 PM
Here, thanks :)

Basically, it's just the same two files that were there before - only repacked as a zip, and without any of the fluff in the tgz. Works fine on final as far as I can tell.
Title: Re: Error Log Counter
Post by: Spoogs on July 07, 2011, 07:01:54 PM
Done... there was no version bump or anything correct (not that it matters much)?
Title: Re: Error Log Counter
Post by: Gruffen on July 07, 2011, 07:13:19 PM
Nope, it was to all intents and purposes the same mod - just in a zip rather than .tgz file.
Title: Re: Error Log Counter
Post by: kcmartz on October 31, 2011, 12:17:13 PM
Quote from: cσσкιє мσηѕтєя on January 01, 2011, 09:39:11 PM
DS, kcmartz is saying that thanks to this mod, he noticed those 20,000 errors that he had before he installed it...
Been inactive, but that's what I meant, yes.
Title: Re: Error Log Counter
Post by: Flavio93Zena on May 05, 2014, 07:12:48 PM
Very old topic but just a quick tip to anyone who might read this: still works in 2.0.7 with no errors.
Title: Re: Error Log Counter
Post by: venguard223 on May 08, 2014, 01:36:32 PM
Yeah, the code is sufficiently unchanged since the RC days in those areas that it should work fine.