Messages

  Entire forum

Auto Light Dark

English

Bug fixed 

Look in root/Themes/default/languages/sd_language/Notifications.english.php

With the change in Packes.php is not resolved. There is still no information when and if the plugin is installed. Look at the first image.

If the variable $packages is removed  then the information is displayed.  But the modification type is not recognized. Look at the last image.
Packes.php

Code (php) Select Expand

        call_integration_hook('integrate_packages_sort_id', array(&$sort_id));
Subs-SimpleDeskPackages.php

Code (php) Select Expand

function shd_packages_sort_id(&$sort_id)
{
    global $context;

    $sort_id['sdplugin'] = 1;
    $context['available_sdplugin'] = array();
}


The plugin is installed. But can not be uninstalled, because the wrong button is displayed. Look at the first image.

For the FrontPage plugin in Ticket Index, I suggest a new design. First image is the old design, and the last my suggestion. If this style like, I make a request via Github.

Pull request => https://github.com/SimpleDesk/SimpleDesk/pull/36

  Many thanks 

One step I continued
when in Packes.php change from

Code (php) Select Expand

function PackageBrowse()
{
    global $txt, $scripturl, $context, $forum_version, $sourcedir, $smcFunc;

    $context['page_title'] .= ' - ' . $txt['browse_packages'];

    $context['forum_version'] = $forum_version;
    $context['modification_types'] = array('modification', 'avatar', 'language', 'unknown');

    call_integration_hook('integrate_modification_types');

to

Code (php) Select Expand

function PackageBrowse()
{
    global $txt, $scripturl, $context, $forum_version, $sourcedir, $smcFunc;

    $context['page_title'] .= ' - ' . $txt['browse_packages'];
    $context['forum_version'] = $forum_version;

    $type = array('modification', 'avatar', 'language', 'unknown');

    $context['modification_types'] = $type;

    call_integration_hook('integrate_modification_types');

works the hook "integrate_modification_types" and  any modification type can be added. Then only missing the information, if and when installed. If the variable "$packes" to function "shd_packages_sort_id" added, the modification type is no longer detected. But it appears the information if and when installed. 

?There seems to be a bug to with SMF call_integration_hook ('integrate_modification_types');?  There the modification type is not recognized, please look at image pluginsystem-3.PNG

Subs-SimpleDeskPackages.php

Code (php) Select Expand

/**
*    Sets up the browse section for plugins.
*
*    @since 2.1
*/
function shd_modification_types()
{
    global $context, $txt;

    $context['modification_types'][] = 'sdplugin';
}

sources/Packes.php

Code (php) Select Expand

    $context['modification_types'] = array('modification', 'avatar', 'language', 'unknown');

only when I change in Subs-SimpleDeskPackages.php this to

Code (php) Select Expand

    $context['modification_types'] = array('modification', 'avatar', 'language', 'unknown', 'sdplugin');
is he modification type is detected. For this purpose, I have to remove the variable $packes in Hook integrate_packages_sort_id

Code (php) Select Expand

function shd_packages_sort_id(&$sort_id, &$packages)
{
    global $context, $packages;But then missing the information that this plugin is installed and when it was installed, please look at image pluginsystem-4.PNG

install.php

find

Code (php) Select Expand

    $hooks[] = array(
        'hook' => 'integrate_package_upload',
        'function' => 'shd_package_upload',
        'file' => '$sourcedir/sd_source/Subs-SimpleDeskPackages.php',
        'perm' => true,
    );
add after

Code (php) Select Expand

    $hooks[] = array(
        'hook' => 'integrate_modification_types',
        'function' => 'shd_modification_types',
        'file' => '$sourcedir/sd_source/Subs-SimpleDeskPackages.php',
        'perm' => true,
    );

sd_language/SimpleDeskAdmin.english.php

find

Code (php) Select Expand

$txt['shd_search_rebuilt'] = 'The search index has been rebuilt.';
//@}
add after

Code (php) Select Expand



//! Package Plugin
//@{
$txt['sdplugin_package'] = 'SDPlugin packages';
//@}

In Subs-SimpleDeskPackages.php missing variable
$scripturl
$txt
$packages

find

Code (php) Select Expand

function shd_packages_sort_id(&$sort_id, &$packages)
{
    global $context;
replaces with

Code (php) Select Expand

function shd_packages_sort_id(&$sort_id, &$packages)
{
    global $context, $packages;

find

Code (php) Select Expand

function shd_package_download()
{
    global $context;
replaces with

Code (php) Select Expand

function shd_package_download()
{
    global $context, $scripturl, $txt;

find

Code (php) Select Expand

function shd_package_upload()
{
    global $context;
replace with

Code (php) Select Expand

function shd_package_upload()
{
    global $context, $scripturl, $txt;

Please look at github => https://github.com/wintstar/Testing/commit/2a6644b0641cb85f6984ea0c06569fe3bbfa42dc

Sorry, but create a request to github, I still do not understand 

Thanks @SleePy     I knew until now not that this can be so solved. Will look into SMF Wiki again.

   I can not confirm the bug from @tfs. In the error log  has this bug not reported with the latest version from SMF 2.1 *.

   That is right, is tricky. Some German words are longer than in English.

I'll change that with my German language pack with install.xml.