[Feedback] Attachments

Started by Gruffen, April 08, 2010, 06:05:14 PM

Previous topic - Next topic

Gruffen

Bump.

People are still saying it doesn't look as good as it might... how would you make it look better?

Yagiz

Quote from: Yagiz on April 09, 2010, 01:26:18 PM
Making attachments on replies horizantaly and 4 attachments in a row should be better :)

+ if the attachment has a thumbnail, add an icon next to it and when hovering, show the attachment.

Gruffen

Showing the attachment thumbnail or fullsize?

Yagiz

Hmmm, fullsize. If we show thumbnails, how can they see fullsizes? :)

feline

I like it, to put a small icon and the link in the ticket or the comment. So it's clear who have upload the attach.
And if the icon (or the text) have a link to the full size image, then it's not problem to open this in a popup or (better) with HighSlide ...

Fel

PortaMx has released version 1.4 for SMF 2.0 with revolutionary features, which no other portal has. This is only possible with the PortaMx 'OOP' programming technique and the built in 'SEF' engine.

Gruffen

Well, the small icon as I mentioned earlier in this thread is already there, it went in almost 30 revisions ago.

Thumbnails seems to be a big thing, so I'll definitely look into that when I'm back.

feline

#21
I have tested that with a smal icon and a HighSlide link ..

foreach ($context['ticket_attach']['ticket'] as $attachment)
echo '
<div class="description shd_attachment" id="attach', $attachment['id'], '">
<a href="', $attachment['href'], '" id="link_', $attachment['id'], '" onclick="return hs.expand(this, {align: \'center\', captionText: \''. $attachment['name'] .'\'})">
<img src="', $settings['default_images_url'], '/simpledesk/preview.png" alt="x" title="', $txt['pmx_hs_expand'] ,'" />
</a>
<strong>', $attachment['link'], '</strong>
<span class="smalltext">
(', $attachment['size'], ')
</span>
</div>';

Works great  ;)

Fel

PortaMx has released version 1.4 for SMF 2.0 with revolutionary features, which no other portal has. This is only possible with the PortaMx 'OOP' programming technique and the built in 'SEF' engine.

Gruffen

* Arantor wonders how much reverting of r542 will be required to remove the icons already there.

Note that that still doesn't remove the overhead of hundreds of lines of code from Display.php being ported to SimpleDesk-Display.php